Skip to content

Fix signedness in GMP FFI bindings#16799

Open
kojix2 wants to merge 1 commit intocrystal-lang:masterfrom
kojix2:gmp
Open

Fix signedness in GMP FFI bindings#16799
kojix2 wants to merge 1 commit intocrystal-lang:masterfrom
kojix2:gmp

Conversation

@kojix2
Copy link
Copy Markdown
Contributor

@kojix2 kojix2 commented Mar 31, 2026 

grep -C1 -e __gmpq_cmp_si -e __gmpf_pow_ui /usr/include/gmp.h
#define _mpq_cmp_si __gmpq_cmp_si
__GMP_DECLSPEC int _mpq_cmp_si (mpq_srcptr, long, unsigned long) __GMP_ATTRIBUTE_PURE;
--

#define mpf_pow_ui __gmpf_pow_ui
__GMP_DECLSPEC void mpf_pow_ui (mpf_ptr, mpf_srcptr, unsigned long int);

@kojix2 kojix2 marked this pull request as draft April 2, 2026 06:38
@kojix2 kojix2 marked this pull request as ready for review April 2, 2026 15:52
@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:numeric labels Apr 7, 2026
@ysbaddaden ysbaddaden added this to the 1.20.0 milestone Apr 7, 2026
Sija
Sija reviewed Apr 7, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ysbaddaden ysbaddaden ysbaddaden approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

+1 more reviewer

@Sija Sija Sija left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:numeric

Projects

None yet

Milestone

1.20.0

Development

Successfully merging this pull request may close these issues.

4 participants

@kojix2 @Sija @ysbaddaden @straight-shoota